Open
Conversation
The previous implementation was error prone as it triggered a deprecated config option warning unnecessarily. Luckily 3 years ago a proper solution was implemented in OpenStack for being able to set the backend service name and backend cluster name (which we don't do yet).
dirkmueller
force-pushed
the
cinder_volume_ha_rework
branch
from
809b53b to
abeca01
Compare
vuntz
suggested changes
Mar 9, 2017
| "cluster:#{CrowbarPacemakerHelper.cluster_name(node)}" | ||
| ) | ||
| backend_host = CrowbarPacemakerHelper.cluster_vhostname(node) | ||
| end |
Member
There was a problem hiding this comment.
I'd prefer to explicitly have backend_host set to nil. We can just rewrite:
backend_host = if CrowbarPacemakerHelper.cluster_enabled?(node) &&
node[:cinder][:elements]["cinder-volume"].include?(
"cluster:#{CrowbarPacemakerHelper.cluster_name(node)}"
)
CrowbarPacemakerHelper.cluster_vhostname(node)
end| default[:cinder][:verbose] = false | ||
| default[:cinder][:max_header_line] = 16384 | ||
| default[:cinder][:config_file] = "/etc/cinder/cinder.conf.d/100-cinder.conf" | ||
| default[:cinder][:config_file_cinder_volume] = "/etc/cinder/cinder-volume.conf.d/100-cinder-volume.conf" |
Member
There was a problem hiding this comment.
Shouldn't we remove this file from the filesystem, for people who had deployed things before this patch?
Member
|
Should this be closed or revived? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.